This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Fix an unclosed transport error in test_events #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the asyncio unit tests, I noticed that I was seeing the
following error from test_ssl_connect_accepted_socket():
/Volumes/ronf/src/asyncio/asyncio/sslproto.py:328: ResourceWarning:
unclosed transport <asyncio.sslproto._SSLProtocolTransport object at
0x10d7d57b8>
warnings.warn("unclosed transport %r" % self, ResourceWarning)
This commit fixes this error by calling close on the transport which is
opened rather than calling close on the socket of the accepted
connection used to create it.
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the asyncio unit tests, I noticed that I was seeing the
following error from test_ssl_connect_accepted_socket():
/Volumes/ronf/src/asyncio/asyncio/sslproto.py:328: ResourceWarning: unclosed transport <asyncio.sslproto._SSLProtocolTransport object at 0x10d7d57b8>
warnings.warn("unclosed transport %r" % self, ResourceWarning)
This commit fixes this error by calling close on the transport which is
opened rather than calling close on the socket of the accepted
connection used to create it.